search

dstreett / Super-Deduper

An application to remove PCR duplicates from high throughput sequencing runs.
11 stars 4 forks source link

Testing #35

Closed bioSandMan closed 8 years ago

bioSandMan commented 8 years ago

basic tests are working.

dstreett commented 8 years ago

Hey, @bioSandMan . One more question - when I merged it into develop, I keep getting an error "Unable to find test files". I pushed it up to test_develop (with proposed indent change as well). Any suggestions on why this is happening?

Thank you for your help!

bioSandMan commented 8 years ago

Did you figure this one out? If it's complaining about the test files then it's unable to find one of the fastq datasets. The test is looking for specific files, so either the files don't exist or it's finding extra fastq files that it didn't expect. Check to make sure your .gitignore isn't listing fastq files or add them explicitly.

bioSandMan commented 8 years ago

Found it. It was on my end. I decided that we didn't need to test the file compare since I was testing specific expected entries in the output. Also, my merge isn't pulling the changes in the output for Super Deduper.

dstreett commented 8 years ago

Fetch origin/develop and then merge develop into your testing branch and you should see it.

I pushed a branch (maybe testing_develop or something like that) yesterday which should have done this exact thing if you want to look at it.

Let me know if you have any questions.

On May 31, 2016, at 12:55 PM, Christopher Mirabzadeh notifications@github.com wrote:

Found it. It was on my end. I decided that we didn't need to test the file compare since I was testing specific expected entries in the output. Also, my merge isn't pulling the changes in the output for Super Deduper.

On Tue, May 31, 2016 at 11:42 AM, Christopher Mirabzadeh < camirabzadeh@gmail.com> wrote:

Did you figure this one out? If it's complaining about the test files then it's unable to find one of the fastq datasets. The test is looking for specific files, so either the files don't exist or it's finding extra fastq files that it didn't expect. Check to make sure your .gitignore isn't listing fastq files or add them explicitly.

-ChrisM

On Mon, May 30, 2016 at 3:11 PM, David Streett notifications@github.com wrote:

Hey, @bioSandMan https://github.com/bioSandMan . One more question - when I merged it into develop, I keep getting an error "Unable to find test files". I pushed it up to test_develop (with proposed indent change as well). Any suggestions on why this is happening?

Thank you for your help!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/dstreett/Super-Deduper/pull/35#issuecomment-222560218, or mute the thread https://github.com/notifications/unsubscribe/AG5bJeDpy0UGEH2dnLsvIXIIsvEpCzqfks5qG2CFgaJpZM4IfsUg .

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

bioSandMan commented 8 years ago

I merged test_develop into testing and everything seems to be working. I pushed the changes back to the testing branch.