search

dsuarezv / mavlink.net

A better MavLink object generation for C#. Richer message classes are generated from the object definitions.
38 stars 35 forks source link

Supporting v2.0 #23

Open tuloski opened 6 years ago

tuloski commented 6 years ago

Is this supporting MAVlink v2.0? Because the standard c# generators of pymavlink don't work properly.

MartinStokelj commented 4 years ago

Is this supporting MAVlink v2.0?

MikaelFerland commented 4 years ago

I did it here, but some part is missing regarding the message signing and I did not test with the log file https://github.com/MikaelFerland/mavlink.net/tree/protocol_upgrade

dsuarezv commented 4 years ago

Nice!

MartinStokelj commented 4 years ago

This code will be able to read mavlink1 and mavlink2? Can you give more info how it will decide which protocol it is?

MikaelFerland commented 4 years ago

@MartinStokelj I follow the protocol here https://mavlink.io/en/guide/mavlink_2.html and it's backward compatible with MAVLink v1.0 @dsuarezv could I do a pull request?

MartinStokelj commented 3 years ago

I beleave something is not ok with the protocol. According to link MAVLink 2 truncates any zero-filled bytes at the end of the payload before the message is sent and sets the packet len field appropriately (MAVLink 1 always sends all bytes). I think this is not implemented

MikaelFerland commented 3 years ago

Your right I forgot this part.

ha-ves commented 2 years ago

will this upgrade pull request get approved?