dsully / perl-crypt-openssl-x509

Perl interface to OpenSSL's X509 module.
Other
25 stars 33 forks source link

use double quote for interpolation in Makefile.PL #108

Closed skaji closed 2 years ago

skaji commented 2 years ago

Description

@jonasbn Thank you for releasing Crypt-OpenSSL-X509-1.914-TRIAL!

I found a tiny problem: On my macOS 12.3 with homebrew's openssl v3, make fails:

cc -c  -I/usr/local/opt/openssl@3/include -fno-common -DPERL_DARWIN -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -DPERL_USE_SAFE_PUTENV -Wno-error=implicit-function-declaration -DOPENSSL_API_COMPAT=pi_ver -O2 -g -Wall -Wno-deprecated-declarations -Wno-compound-token-split-by-macro   -DVERSION=\"1.914\" -DXS_VERSION=\"1.914\"  "-I/Users/skaji/env/plenv/versions/relocatable-5.34.1.0/lib/5.34.1/darwin-2level/CORE"   X509.c

In file included from X509.xs:5:
In file included from /usr/local/opt/openssl@3/include/openssl/asn1.h:19:
/usr/local/opt/openssl@3/include/openssl/macros.h:155:4: error: "OPENSSL_API_COMPAT expresses an impossible API compatibility level"
#  error "OPENSSL_API_COMPAT expresses an impossible API compatibility level"
   ^
1 error generated.
make: *** [X509.o] Error 1

You can see -DOPENSSL_API_COMPAT=pi_ver, but it must be -DOPENSSL_API_COMPAT=0x10100000L. This PR changes Makefile.PL to fix the compile option.

Type of change

Please delete options that are not relevant.

Checklist

Test / Development Platform Information