search

dsully / perl-crypt-openssl-x509

Perl interface to OpenSSL's X509 module.
Other
25 stars 33 forks source link

-Werror creates problems #45

Closed chorny closed 2 years ago

chorny commented 9 years ago

Strawberry perl 5.18 has

/* #define USE_PERL_SBRK    /**/

in win32.h, which with "-Werror" dies with

error: "/*" within comment [-Werror=comment]

See for ex. http://www.cpantesters.org/cpan/report/6b653933-6c13-1014-a8f7-67a372e8df79

jonasbn commented 4 years ago

So the suggestion is to tweak the compiler flags for Windows to avoid this issue?

jonasbn commented 2 years ago

My proposed solution is to add:

-Wnoerror= comment in Makefile.PL

But I cannot test it currently and make sure it works, since I cannot reproduce it.