search

dsuryd / dotNetify

Simple, lightweight, yet powerful way to build real-time web apps.
https://dotnetify.net
Other
1.17k stars 164 forks source link

Issue with Customized with Json serializations configuration #195

Closed mason-chase closed 5 years ago

mason-chase commented 5 years ago

Hi,

UseJsonSerializerSettings currently doesn't allow access to original VMSerializer.SerializerSettings value to avoid serializing Action and ICommand properties.

To VMContractResolver to work properly I have added additional methods to give us better direct access to instantiate Dotnetify's Json converter.

Regards Mason

mason-chase commented 5 years ago

Apparently there are existing code in the project that doesn't meet the standard, should I make further changes on other areas to suppress the code standard error?

dsuryd commented 5 years ago

Looks good. The failing standard check looks to be false positive, can be ignored.
Could you add the unit test in DotNetifyConfigurationTest.cs?