dsuryd / dotNetify

Simple, lightweight, yet powerful way to build real-time web apps.
https://dotnetify.net
Other
1.17k stars 164 forks source link

Upgrade from 3.6.2 to 3.7.0 - Redirecting to 404.html #246

Closed treg closed 4 years ago

treg commented 4 years ago

We have been using DotNetify since 3.3.1. Without changing any of our code and after upgrading from 3.6.2 to 3.7.0, dotNetify will auto redirect to 404.html. However, If I add "dotnetify.react.router.urlPath = null;" before calling connect, everything works as before.

I believe the issue is in dotnetify-vm-router.ts line # 88

Please assist.....

-- our pre-connect setup --

import dotnetify from 'dotnetify'; dotnetify.hubServerUrl = document.location.origin + '/' + document.location.pathname.split('/')[1];; dotnetify.debug = (!process.env.NODE_ENV || process.env.NODE_ENV === 'development');

//added to prevent auto redirect to 404.html dotnetify.react.router.urlPath = null;

dsuryd commented 4 years ago

I just published 3.7.1 to correct the faulty logic. Let me know whether it fixes the issue.

treg commented 4 years ago

upgraded to 3.7.1; it works almost :)
still see "router> routed (404)" in the browser debugger window. but it does not route

dsuryd commented 4 years ago

It's an expected debug message. The wording may change in the future since it's misleading if you're not using dotNetify routing, but shouldn't be a problem for closing this issue. Thanks!

treg commented 4 years ago

Thank you for the quick turnaround.

Yes, I can live with that erroneous debug message.

On Mon, May 18, 2020, 10:17 AM Dicky Suryadi notifications@github.com wrote:

It's an expected debug message. The wording may change in the future since it's misleading if you're not using dotNetify routing, but shouldn't be a problem for closing this issue. Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dsuryd/dotNetify/issues/246#issuecomment-630251785, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAF4Y3GIRJO25FNTZIZBUGLRSFGQBANCNFSM4NDXBZTA .