dsv-su / play

Dev repository for Play
0 stars 1 forks source link

Mediasite import should respect offline and private statuses #85

Closed orkit closed 2 years ago

orkit commented 2 years ago

When importing presentations from media sites, I discovered that a presentation that has been marked as hidden in media sites appears in the import list in the mediasite import tool. Should hidden media site presentations be imported? If not, it should be avoided or there should be a way to opt it out manually. Screenshot 2022-01-27 at 11 22 04 Screenshot 2022-01-27 at 11 22 19

It would also be good if individual presentations in the list could be deselected.

pavelsokolov commented 2 years ago

We don't respect any privacy and permission settings created on mediasite, so we import all presentations.

We can of course enhance the mediasite import interface, but I am not sure if it's reasonable. The idea was to import presentations in batches, and then disconnect mediasite recorders, so this import won't be used regularly. So I'd suggest leaving it until we're done with other issues.

orkit commented 2 years ago

I mean that if we import a batch of older presentations and the teacher has explicitly set in mediasite that that presentation should not be viewable, it still will be imported (It could be easy to make a mistake here). I do not mean to change the media site interface in any way, but wonder if there is some kind of flag that can be used so that the presentation does not appear in the list of possible presentations to import.

booski commented 2 years ago

Aren't mediasite imports going to be done on request from the responsible teacher anyway? In that case I suggest one of these options:

pavelsokolov commented 2 years ago

It's not a problem to get the presentation status (offline, private) and append 'visiblity: 0' to the passed json. In that case we migrate everything and save the visibility setting. But that requires play-store not stripping that attribute away.

Screenshot 2022-02-03 at 18 16 35
booski commented 2 years ago

The daemon on play-store has been updated.

If a mediasite import job includes a "visibility" field next to the "id", "title", etc fields, it will now be passed on. If the field doesn't exist it will be populated with an empty string. This should probably change to some sane default or simply always expect the field to be present.

pavelsokolov commented 2 years ago

'visibility' attribute is now passed to play-store for mediasite presentations (f73d3ade14cca665f48eef4b3a913b255198d297), it's set to 0 when the presentation is either 'offline' or 'private'.

pavelsokolov commented 2 years ago

Fixed in f73d3ade14cca665f48eef4b3a913b255198d297