dsw / oink-stack

Oink is a collaboration of C++ static analysis tools.
http://danielwilkerson.com/oink/index.html
154 stars 34 forks source link

Update to elkhound/Makefile.in #9

Closed robertmichaelwalsh closed 10 years ago

robertmichaelwalsh commented 10 years ago

This fixes compilation issues under Linux. To be more specific, the call to gcc for the Bison-generated files was missing the include of the smbase and ast paths, whose header files are required.

There was also an issue with the initialiser for yyval, I have changed that line so that the initialiser is now (I think) safe for union types.

dsw commented 10 years ago

Robert, I looked at the diff and I don't see any changes that would correspond to this comment: "To be more specific, the call to gcc for the Bison-generated files was missing the include of the smbase and ast paths, whose header files are required." Did you make a change that added some #include lines but then not commit them? Or am I missing something here?

Daniel

On Mon, Nov 18, 2013 at 4:41 AM, Robert Michael Walsh notifications@github.com wrote:

This fixes compilation issues under Linux. To be more specific, the call to gcc for the Bison-generated files was missing the include of the smbase and ast paths, whose header files are required.

There was also an issue with the initialiser for yyval, I have changed that line so that the initialiser is now (I think) safe for union types.


You can merge this Pull Request by running

git pull https://github.com/robertmichaelwalsh/oink-stack master

Or view, comment on, or merge it at:

https://github.com/dsw/oink-stack/pull/9

Commit Summary

GCC call for compiling Bison-generated files requires CCFLAGS under Linux. Also changed initialiser for yyval to one that is safe for union types.

File Changes

M elkhound/Makefile.in (4)

Patch Links:

https://github.com/dsw/oink-stack/pull/9.patch https://github.com/dsw/oink-stack/pull/9.diff