Tried to make the java example a bit more java-style

[erilor]

Inspired by #1 I tried to make the Java example a bit more "java-style". Is this something you would be interested incorporating?

The masking part of uint2quint seems to be superfluous to me, am I missing something? I removed it and only left the bit shift, and it seems to work.

The my_atoi could be replaced with Integer.parseUnsignedInt, I only added a comment about it, since I saw that you had kept it to keep in line with the c implementation. The current implementation only allows half of the value space since it checks against Integer.MAX_VALUE, switching to parseUnsignedInt would allow the full space to be used. I don't know if this is an intended limitation?

Anyway, thanks for a really novel idea! I'm sure it will make people's lives a bit less frustrating =)

[dsw]

When editing someone else's code, do not gratuitously change their comment or indentation style.

Why would you replace Readers with Strings? Streaming interfaces are fundamentally more efficient.

[erilor]

My intention was to make the code easily readable for java-developers, the original code (in my opinion) reads more like c-code. Comments in java are usually written according to javadoc (https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html). But I can agree that changing the comment formatting may have been a bit overzealous. Changing Readers to Strings was to try and make the code more easily understandable (again in my opinion). I wasn't trying to make it efficient.

If you would be interested in the change with any adaptions (like removing formatting changes and/or reintroducing Readers) let me know.

I wish you a Happy new year!

[dsw]

A Reader is a fundamentally more general concept than a String, as it can decode any stream of data, such as coming from a file or off of the network.

You do not know what you are doing. Stop contacting me.

On Sat, Dec 25, 2021 at 11:02 PM Erik Lorentzson @.***> wrote:

My intention was to make the code easily readable for java-developers, the original code (in my opinion) reads more like c-code. Comments in java are usually written according to javadoc ( https://www.oracle.com/technical-resources/articles/java/javadoc-tool.html). But I can agree that changing the comment formatting may have been a bit overzealous. Changing Readers to Strings was to try and make the code more easily understandable (again in my opinion). I wasn't trying to make it efficient.

If you would be interested in the change with any adaptions (like removing formatting changes and/or reintroducing Readers) let me know.

I wish you a Happy new year!

— Reply to this email directly, view it on GitHub https://github.com/dsw/proquint/pull/15#issuecomment-1001115332, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAL6XHCZKWRUUZ2NE3HHW3US24XNANCNFSM5BACY6CQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

[erilor]

You said that the example should be "simple and readable by a human". So that is what I tried to do.

I never said Strings were more general or versatile (or faster), I only said that it was easier to understand. I also explicitly said it was only my opinion (and offered to adapt it to your liking).

From that, you felt the need to be rude and make a personal attack…

Oh well, you will not hear from me again.

[dsw]

You lack a basic understanding of how to write software. In particular, you (1) do not make gratuitous changes to someone else's code and (2) you do not make code less general unless doing so also makes it dramatically simpler.

Further, you pretend criticism of your design is a personal attack, whereas it is just part of the engineering process. Being an engineer requires competence and when you fail to display it, you are wasting the time of others. Pretending that criticism of your design is a personal attack is a common failure mode and you don't seem to know even that.

On Mon, Jan 3, 2022 at 12:59 AM Erik Lorentzson @.***> wrote:

You said that the example should be "simple and readable by a human". So that is what I tried to do.

I never said Strings were more general or versatile (or faster), I only said that it was easier to understand. I also explicitly said it was only my opinion (and offered to adapt it to your liking).

From that, you felt the need to be rude and make a personal attack…

Oh well, you will not hear from me again.

— Reply to this email directly, view it on GitHub https://github.com/dsw/proquint/pull/15#issuecomment-1003948198, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAL6XG6LAUYE2TFWWFT46DUUFQNLANCNFSM5BACY6CQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

[erilor]

"You do not know what you are doing" is criticism of my design that I'm misrepresenting as personal attack? Well alrighty then…

I suppose "You lack a basic understanding of how to write software" is also just some well-intentioned feedback.

Encourage constructive disagreements, condemn abusive tones in disagreements Venkat

I really don't understand why you're lashing out like this, but this obviously isn't constructive. I've closed the pull request and have no further interest in it. I'm certainly not interested in any more "insights" from you. Move on!

[dsw]

(1) You contacted me, not the reverse.

(2) You do not know how to write software.

(3) You are wasting my time.

On Tue, Jan 4, 2022 at 4:01 AM Erik Lorentzson @.***> wrote:

"You do not know what you are doing" is criticism of my design that I'm misrepresenting as personal attack? Well alrighty then…

I suppose "You lack a basic understanding of how to write software" is also just some well-intentioned feedback.

Encourage constructive disagreements, condemn abusive tones in disagreements Venkat

I really don't understand why you're lashing out like this, but this obviously isn't constructive. I've closed the pull request and have no further interest in it. I'm certainly not interested in any more "insights" from you. Move on!

— Reply to this email directly, view it on GitHub https://github.com/dsw/proquint/pull/15#issuecomment-1004749840, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAL6XHQNUEICI2F6AKHE53UULOS5ANCNFSM5BACY6CQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>