Open chiqunz opened 5 years ago
In terms.py line 1008, it is possible to violate term.validate_argument if I set n_splines and spline_order as a list. For example:
terms.py
term.validate_argument
n_splines
spline_order
kwargs = {n_splines=[2, 100, 10, 5], spline_order=[1, 3, 1, 3]} LinearGAM(**kwargs).fit(X, y)
I believer the reason is the default spline_order is 3 and we set n_splines before spline_order. So we could come across a case n_splines = 2 and spline_order=3 which will fail in validate_argument.
n_splines = 2
spline_order=3
validate_argument
In
terms.py
line 1008, it is possible to violateterm.validate_argument
if I setn_splines
andspline_order
as a list. For example:I believer the reason is the default
spline_order
is 3 and we setn_splines
beforespline_order
. So we could come across a casen_splines = 2
andspline_order=3
which will fail invalidate_argument
.