search

dswah / pyGAM

[HELP REQUESTED] Generalized Additive Models in Python
https://pygam.readthedocs.io
Apache License 2.0
862 stars 159 forks source link

modify order of param validation in gridsearch #251

Open dswah opened 5 years ago

dswah commented 5 years ago

We need to validate the data-dependent model parameters after validating the data!

this fixes https://github.com/dswah/pyGAM/issues/245 and fixes https://github.com/dswah/pyGAM/issues/246 and fixes https://github.com/dswah/pyGAM/issues/232

codecov[bot] commented 5 years ago

Codecov Report

Merging #251 into master will increase coverage by 0.14%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #251      +/-   ##
=========================================
+ Coverage   95.05%   95.2%   +0.14%     
=========================================
  Files          22      22              
  Lines        3178    3192      +14     
=========================================
+ Hits         3021    3039      +18     
+ Misses        157     153       -4
Impacted Files Coverage Δ
pygam/pygam.py 94.8% <100%> (ø) :arrow_up:
pygam/tests/test_gridsearch.py 100% <100%> (ø) :arrow_up:
pygam/utils.py 87.73% <0%> (+0.3%) :arrow_up:
pygam/tests/test_GAM_methods.py 100% <0%> (+0.36%) :arrow_up:
pygam/tests/test_utils.py 96.5% <0%> (+1.39%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2942579...5cecb3f. Read the comment docs.