search

dswah / pyGAM

[HELP REQUESTED] Generalized Additive Models in Python
https://pygam.readthedocs.io
Apache License 2.0
862 stars 159 forks source link

replace combine with itertools product #253

Open dswah opened 5 years ago

dswah commented 5 years ago

for large search-spaces, gridsearch can easily exhaust all available memory before fitting a single model. This is because the method tries to pre-determine the entire search space in memory.

we could instead use a generator like itertools.product

this fixes https://github.com/dswah/pyGAM/issues/242

TO-DO

codecov[bot] commented 5 years ago

Codecov Report

Merging #253 into master will increase coverage by 0.01%. The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #253      +/-   ##
=========================================
+ Coverage   95.18%   95.2%   +0.01%     
=========================================
  Files          22      22              
  Lines        3178    3169       -9     
=========================================
- Hits         3025    3017       -8     
+ Misses        153     152       -1
Impacted Files Coverage Δ
pygam/utils.py 87.61% <ø> (-0.12%) :arrow_down:
pygam/pygam.py 94.81% <91.66%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b5c6c55...df68aac. Read the comment docs.