search

dswah / pyGAM

[HELP REQUESTED] Generalized Additive Models in Python
https://pygam.readthedocs.io
Apache License 2.0
857 stars 157 forks source link

pygam/{core,pygam}: fix literal identity check #261

Closed squat closed 4 years ago

squat commented 4 years ago

This commit changes the checks against literal values from identity to equality, as recommended in Python 3.8.

Fixes: https://github.com/dswah/pyGAM/issues/260

Signed-off-by: Lucas Servén Marín lserven@gmail.com

codecov[bot] commented 4 years ago

Codecov Report

Merging #261 into master will increase coverage by 0.15%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #261      +/-   ##
==========================================
+ Coverage   95.05%   95.21%   +0.15%     
==========================================
  Files          22       22              
  Lines        3178     3178              
==========================================
+ Hits         3021     3026       +5     
+ Misses        157      152       -5
Impacted Files Coverage Δ
pygam/core.py 90.62% <100%> (ø) :arrow_up:
pygam/pygam.py 94.79% <100%> (ø) :arrow_up:
pygam/terms.py 94.41% <0%> (+0.19%) :arrow_up:
pygam/utils.py 87.73% <0%> (+0.3%) :arrow_up:
pygam/tests/test_GAM_methods.py 100% <0%> (+0.36%) :arrow_up:
pygam/tests/test_utils.py 96.5% <0%> (+1.39%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2942579...684ddb6. Read the comment docs.

TariqAHassan commented 4 years ago

Bump.

dswah commented 4 years ago

@squat Thank you very much!! and also thanks to @tirkarthi @TariqAHassan for the reminder!

I am so sorry to be so slow to review this PR.