shyamcody commented 4 years ago

Made the following changes: (1) type_ changed to output. (2) changed the documentation for return. (3) added test function to check the shape as well as valueError.

codecov[bot] commented 4 years ago

Codecov Report

Merging #277 into master will decrease coverage by 0.15%. The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master     #277      +/-   ##
==========================================
- Coverage   95.21%   95.06%   -0.16%     
==========================================
  Files          22       22              
  Lines        3178     3202      +24     
==========================================
+ Hits         3026     3044      +18     
- Misses        152      158       +6

Impacted Files	Coverage Δ
pygam/distributions.py	`88.40% <ø> (ø)`
pygam/tests/test_GAM_methods.py	`98.97% <88.88%> (-1.03%)`	:arrow_down:
pygam/pygam.py	`94.83% <91.66%> (+0.03%)`	:arrow_up:
pygam/tests/test_utils.py	`95.10% <0.00%> (-1.40%)`	:arrow_down:
pygam/utils.py	`87.42% <0.00%> (-0.31%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b57b4cf...e6df9ad. Read the comment docs.

shyamcody commented 4 years ago

@dswah just check this pull once. All of the tests have passed successfully; so probably good to go.

shyamcody commented 4 years ago

Changed the gamma parameter from being default in 1.4 to a user side parameter. #76 should be solved with this. Successfully added gamma and test.

shyamcody commented 3 years ago

@dswah can you merge this change for now? I tried my hand with further development; but seems I am not able to do anything for now. So would like to get this merged.

dswah / pyGAM

[WIP]-corrected the #275 pull request #277

Codecov Report