search

dswah / pyGAM

[HELP REQUESTED] Generalized Additive Models in Python
https://pygam.readthedocs.io
Apache License 2.0
871 stars 159 forks source link

empty sparse matrices dont need np.zeros #295

Open dswah opened 3 years ago

dswah commented 3 years ago

we dont need to us np.zeros(...) to initialize an empty sparse matrix (since this would also defeat the purpose)

codecov[bot] commented 3 years ago

Codecov Report

Merging #295 (1326b99) into master (b57b4cf) will increase coverage by 0.06%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #295      +/-   ##
==========================================
+ Coverage   95.21%   95.28%   +0.06%     
==========================================
  Files          22       22              
  Lines        3178     3222      +44     
==========================================
+ Hits         3026     3070      +44     
  Misses        152      152
Impacted Files Coverage Δ
pygam/penalties.py 93.33% <100.00%> (ø)
pygam/terms.py 94.60% <100.00%> (+0.19%) :arrow_up:
pygam/tests/test_terms.py 100.00% <0.00%> (ø)
pygam/pygam.py 94.80% <0.00%> (+<0.01%) :arrow_up:
pygam/tests/test_utils.py 96.55% <0.00%> (+0.04%) :arrow_up:
pygam/callbacks.py 95.23% <0.00%> (+0.07%) :arrow_up:
pygam/distributions.py 88.88% <0.00%> (+0.48%) :arrow_up:
pygam/tests/conftest.py 98.21% <0.00%> (+0.65%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b57b4cf...1326b99. Read the comment docs.