search

dswah / pyGAM

[HELP REQUESTED] Generalized Additive Models in Python
https://pygam.readthedocs.io
Apache License 2.0
852 stars 156 forks source link

fix deprecation warnings for np.int #321

Closed csinva closed 5 months ago

marhoy commented 1 year ago

@davidusb-geek

Please include this PR and make a new release on PyPI. My logs are currently spammed with the deprecation warning from numpy...

davidusb-geek commented 1 year ago

@davidusb-geek

Please include this PR and make a new release on PyPI. My logs are currently spammed with the deprecation warning from numpy...

I naively thought that by approving this PR will be enough for the CI to caugth up an integrate the PR. However, a review of one of the repo owners is needed. So is up to the contributors to do this

marhoy commented 1 year ago

@davidusb-geek Please include this PR and make a new release on PyPI. My logs are currently spammed with the deprecation warning from numpy...

I naively thought that by approving this PR will be enough for the CI to caugth up an integrate the PR. However, a review of one of the repo owners is needed. So is up to the contributors to do this

@dswah : Please approve, merge and release a new version on PyPI (it's been more than 4 years since the last release)... My logs are getting spammed by this DeprecationWarning....

justinchanjinle-forty2science commented 1 year ago

Hi @dswah , any plans to merge and release this on pypi? Thanks for your contribution. Cheers.

jdebacker commented 10 months ago

Including this simple fix in a new pygam release would be great as it's otherwise incompatible with recent versions of Numpy. Thanks!

lauramware commented 5 months ago

I'm also unable to use this package because it's incompatible with recent versions of numpy. @dswah are there plans to release a new version?

lauramware commented 5 months ago

Never mind, I see this was fixed with the latest release so looks like this PR can be closed

dswah commented 5 months ago

pygam versions >= 0.9.0 fix this! please run pip freeze | grep pygam if in doubt about which version you have!