search

dswah / pyGAM

[HELP REQUESTED] Generalized Additive Models in Python
https://pygam.readthedocs.io
Apache License 2.0
852 stars 156 forks source link

Compatibility with numpy 1.24 #325

Closed gedeck closed 1 year ago

gedeck commented 1 year ago

With the latest release of numpy 1.24.0, numpy deprecated and removed np.int. This PR replaces np.int with np.int_. The change was tested using numpy 1.23.5 and numpy 1.24.1 with Python 3.10.9.

If you merge the PR, please release a new version of pyGAM on pypi.

Closes #326

gedeck commented 1 year ago

Having the same problem. If I understand correctly, just using int instead of np.int should solve the problem. Is there any advantage for np.int_?

According to the numpy documentation, int is interpreted as np.int_. I make this change.

Alexander-Serov commented 1 year ago

Thanks! This is how I'm reading numpy's message. 😀

Alexander-Serov commented 1 year ago

@dswah Could you approve?

gedeck commented 1 year ago

Looks like the necessary changes were made to the main code and a new version released recently. I will close the PR.

Thank you for getting the new version out.