search

dswinton / domo-ifttt

Domoticz IFTTT Integration
9 stars 7 forks source link

Invalid device get's mapped to newest IDX device #4

Open MathijsG opened 6 years ago

MathijsG commented 6 years ago

My Yeelight is my latest device, and has IDX 2491 here.

When I do "...domo-ifttt.php?passkey=...&devName=8y8g8g8g8g&devState=1"

It switches the yeelight, with it's latest IDX, while the devname is invalid. Whatever invalid thing I say, it switches this device.

I get this response in browser: " Got requested device name: Got 7 devices from Domoticz Matched on device IDX 2491 All OK - job done "

MathijsG commented 6 years ago

Sounds like, this was issue https://github.com/dswinton/domo-ifttt/issues/2

and I removed the favorites only limitation on line 36. The query takes a little longer now, but it works great. Maybe we can together improve things even further, would be cool if temperature asking would work. Like Controlicz had.

TheDukeSr commented 6 years ago

Issue #2 resolved in fork version (found here).

And Query takes long because the original query reads ALL devices and stays in a loop even after device is found. Solution is to query only needed devices and stop if found. Submitting this in my forked Dev version now (needs testing).

ps. I'm new with Github and still figuring out the push pull thingy. So until i'm sure how to push/pull/merge I keep my Forked version separate from this one.

mbnn commented 5 years ago

Whatever I do... https://myhomeurl/domo-ifttt.php?passkey=mypassxx&devName=LightLiving&devState=1

LightLiving has ID 133, so this makes no sense imo.

I keep getting my garage door opened.....

Got requested device name: Got 9 devices from Domoticz Matched on device IDX 187 All OK - job done

Any idea? Maybe it would be better to do this by device ID instead of by name? :)

Update: That workaround version works! :)