search

dsys / match

:crystal_ball: Scalable reverse image search built on Kubernetes and Elasticsearch
Other
1.25k stars 150 forks source link

Install image-match dynamically #2

Closed rhsimplex closed 8 years ago

rhsimplex commented 8 years ago

Hi @kern and others. Thanks again for the extension to image-match. I noticed you had copied the source files into pavlovml/match and made some modifications. Since your changes to the interface are non-breaking, and your use case is quite clear, we added them to image-match directly: https://github.com/ascribe/image-match/commit/f082e94e442b50e229ca6086d6ed5dfa19f245a1 !

This pull request reflects that update in match. Now image-match is built when the container is built (we tagged this version 0.2).

I've tested this with elasticsearch 2.2.1 running locally and all your API calls work as expected.

kern commented 8 years ago

I had meant to submit a pull req for the bytestream modifications but got caught up. This is awesome, thank so much @rhsimplex! :)