search

dsys / match

:crystal_ball: Scalable reverse image search built on Kubernetes and Elasticsearch
Other
1.24k stars 150 forks source link

Is this project dead? #28

Closed JannikZed closed 6 years ago

JannikZed commented 6 years ago

As there are several opened issues without any answers along with open pull requests I wanted to ask, if this project is still maintained or not.

kern commented 6 years ago

Hey @JannikZed, I'm pretty confident the code works as-is — most issues seem to be related to (mis-)configurations of elasticsearch which are out of scope of this project. Let me know if you run into issues.

JannikZed commented 6 years ago

Hi there, nice to hear that! I just stumbled upon the first problem. Elasticsearch client in your container is in a really old version elasticsearch (2.3.0). Talking with our elastic version 6 cluster is impossible. Do consider enabling a newer version? I can create an pull request really fast using 'elasticsearch>=6.0.0,<7.0.0'

kern commented 6 years ago

That would be great! Happy to merge :)

Sent via Superhuman iOS ( https://sprh.mn/?vip=alex@kern.io )

On Tue, Jun 12 2018 at 3:23 PM, < notifications@github.com > wrote:

Hi there, nice to hear that! I just stumbled upon the first problem. Elasticsearch client in your container is in a really old version elasticsearch (2.3.0). Talking with our elastic version 6 cluster is impossible. Do consider enabling a newer version? I can create an pull request really fast using 'elasticsearch>=6.0.0,<7.0.0'

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub ( https://github.com/dsys/match/issues/28#issuecomment-396753809 ) , or mute the thread ( https://github.com/notifications/unsubscribe-auth/AAAszfswZ6uWa3053-oP3lXR3BI10FBEks5t8D9vgaJpZM4UiT8K ).

JannikZed commented 6 years ago

cool, I placed it in - could you take a look?

kern commented 6 years ago

merged, thanks @JannikZed!

JannikZed commented 6 years ago

cool :) just one more question: the automated build on dockerhub doesn't seem to work any more .. it's written there: "last pushed: a year ago". Could you maybe fix this pipeline, too, so that the newest version can be loaded from dockerhub officially?

kern commented 6 years ago

@JannikZed you can find the automated builds at dsys/match now :)

https://hub.docker.com/r/dsys/match/