search

dszakallas / mixxx-launchpad

Novation Launchpad mapping for Mixxx
MIT License
32 stars 4 forks source link

loop in and out shifted upwards one row in TALL (defualt tall) mode #11

Closed robenimmersatt closed 6 years ago

robenimmersatt commented 6 years ago

So loop IN and OUT is on the same buttons as LOOP and SLIP, and the buttons below are not assigned. This is only an issue in the default tall layout.

dszakallas commented 6 years ago

Hi, sorry for getting back to you so late with this. Yes, it seems this should be at position 3, 3. I am going to fix later today, thanks for reporting.

Swiftb0y commented 6 years ago

Since you fixed said you will fix this. There is no need for a PR. The only other Issue I found is that the Playlist buttons don't get unmounted which should probably be done here. The rest of the mapping works flawless. I am using an MK2 in case you dont encounter this on a LP PRO.

dszakallas commented 6 years ago

There's a problem with dismounting the layout, and the rest of the code is not called. I reordered the dismounts as a workaround, but we'll need a proper solution.

dszakallas commented 6 years ago

fixed in https://github.com/szdavid92/mixxx-launchpad/releases/tag/v2.1.6