search

dt-orders / keptn-orders-setup

"Master" is the latest version. Refer to the "Branch" that maps to the Keptn Version
Apache License 2.0
1 stars 5 forks source link

Make it explicit that the user must not include the protocol on DYNATRACE_HOSTNAME value #9

Closed gabrielprioli closed 4 years ago

gabrielprioli commented 5 years ago

Since you hardcoded the "https://" on [1], either verify it in the code if it already has or tell the user not to put it, right? Otherwise the user might end up with "https://https://"

[1] https://github.com/keptn-orders/keptn-orders-setup/blob/2b91c5e3e69fa016729ea0bb2ab2a979462eb1ce/5-installDynatrace.sh#L21

robertjahn commented 4 years ago

I removed the hardcode in this commit: https://github.com/keptn-orders/keptn-orders-setup/commit/86160c7569c42ba6136a405c2dbf0d19e1396385