search

dtabuenc / karma-html-reporter

Karma Html Reporter Plugin
MIT License
45 stars 30 forks source link

Breaks on Node.js 4.x #29

Closed RIAstar closed 9 years ago

RIAstar commented 9 years ago

karma-html-reporter doesn't play nice with node 4.x An old API is used to handle writeStream errors, which now throws an error.

Here's the stack trace:

TypeError: options must be a string or an object
    at new WriteStream (fs.js:1799:11)
    at Object.fs.createWriteStream (fs.js:1785:10)
    at /home/RIAstar/dev/trasys/seed/angular-app-seed/node_modules/karma-html-reporter/index.js:89:22
    at /home/RIAstar/dev/trasys/seed/angular-app-seed/node_modules/karma/lib/helper.js:82:7
RIAstar commented 9 years ago

As I was preparing a PR for this, I noticed it was already fixed.

However this fix doesn't seem to be included in the latest release on NPM. Any chance you'll be making a new release? It would make sense since currently the only way to make karma-html-reporter work on node 4 is to target the master branch instead of a stable release.

dtabuenc commented 9 years ago

Released 0.2.7

RIAstar commented 9 years ago

Cool, thanks!