sch_cake: heap helpers: use full length variable names

[ldir-EDB0]

Some criticism has been made of using single letter variable names in the heap structure related functions. Use more descriptive variable names to reduce opaqueness of these functions.

Signed-off-by: Kevin Darbyshire-Bryant ldir@darbyshire-bryant.me.uk

Prompted by some of the comments at https://lwn.net/Articles/758353/ I have no idea if this is actually useful or even acceptable to upstream. Thoughts?

[chromi]

As previously noted, these functions are an implementation of a standard, widely-known algorithm for maintaining a simple data structure. Nobody will need to alter these functions without first understanding that algorithm, and the function names clearly describe what they do.

To me, the short names are actually more readable than the long ones proposed here, not least since I don't think "my" for "m" but "middle". One reason the short names are more readable is because they visually align in almost-repeated code, making it easier to see the actual similarities or differences in the code.

I might accept adding a descriptive comment or two, instead - but only if it seem likely to actually help.

• Jonathan Morton

[ldir-EDB0]

That’s fine. I certainly wasn’t that fussed Will close.