Permit use of connmarks as tin classifiers

dtaht / sch_cake

Out of tree build for the new cake qdisc

100 stars 35 forks source link

Permit use of connmarks as tin classifiers #113

Closed ldir-EDB0 closed 5 years ago

ldir-EDB0 commented 5 years ago

Add flag 'FWMARK' to enable use of firewall connmarks as tin selector. The connmark (skbuff->mark) needs to be in the range 1<->tin_cnt ie. for diffserv 3 the mark needs to be 1<->3

Signed-off-by: Kevin Darbyshire-Bryant ldir@darbyshire-bryant.me.uk

tohojo commented 5 years ago

Could you expand the commit message a bit with an explanation for why using fwmark is useful, please? I'm planning to re-use your commit message for the upstream submission, and having that in there is useful :)

ldir-EDB0 commented 5 years ago

Sure, once I've got rid of my blinding headache - uurggh

ldir-EDB0 commented 5 years ago

Have updated the commit message - no idea if coherent!

tohojo commented 5 years ago

Great, thanks!