search

dtaht / sch_cake

Out of tree build for the new cake qdisc
101 stars 35 forks source link

What is tin_quantum_prio used for? Looks unused #121

Closed ldir-EDB0 closed 4 years ago

ldir-EDB0 commented 4 years ago

As per the title I can't find any code that actually uses the tin_quantum_prio variable.

I can find tin_quantum_band used in the tin selection algorithm. We go to some effort to set tin_quantum_prio but I can't find where it's used.

chromi commented 4 years ago

On 16 Dec, 2019, at 9:58 pm, Kevin Darbyshire-Bryant notifications@github.com wrote:

As per the title I can't find any code that actually uses the tin_quantum_prio variable.

I can find tin_quantum_band used in the tin selection algorithm. We go to some effort to set tin_quantum_prio but I can't find where it's used.

I think it's a leftover from an earlier implementation of the Diffserv tins. Now it's done entirely through the shapers' state, except when the shaper is disabled completely.

So it would actually be reasonable to delete that variable and all references to it, as long as tin_quantum_band is still valid.

ldir-EDB0 commented 4 years ago

OK - I'll drop the variable and check nothing goes bang :-)