search

dtaht / sch_cake

Out of tree build for the new cake qdisc
101 stars 35 forks source link

Implement ACK prioritization #131

Closed ckkcc closed 4 years ago

ckkcc commented 4 years ago

ACK prioritization would benefit asymmetric connections. Presumably it's not too difficult since it could reuse some of the ACK filtering code?

https://www.bufferbloat.net/projects/bloat/wiki/ACK_prioritization/

chromi commented 4 years ago

TCP acks are already effectively prioritised because they are small packets. The ack filter further improves performance in practice, by reducing the number of acks that need to get through.

moeller0 commented 4 years ago

I am not sure that the somewhat ancient, prioritize all ACKs indiscriminately approach, ever was really good advice to begin with. IMHO in a tiered priority scheduler ACKs should be kept inside their respective data packet's priority tier. fq_codel's and cake's sparse flow "boosting" does pretty much that by a somewhat simpler heuristic even inside a priority tier.

On Apr 11, 2020, at 17:59, ckkcc notifications@github.com wrote:

ACK prioritization would benefit asymmetric connections. Presumably it's not too difficult since it could reuse some of the ACK filtering code?

https://www.bufferbloat.net/projects/bloat/wiki/ACK_prioritization/

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

dtaht commented 4 years ago

yea, I should nuke that old page. ack prioritization needs to die.