search

dtaht / sch_cake

Out of tree build for the new cake qdisc
101 stars 35 forks source link

qdisc_tree_reduce_backlog appears from 4.1.28 not 4.1.27 #132

Closed odkrys closed 4 years ago

odkrys commented 4 years ago

https://github.com/dtaht/sch_cake/blob/787329d00b5ad5ad1cbd772460ed99f12d762a1a/cobalt_compat.h#L145

check please.

tohojo commented 4 years ago

odkrys notifications@github.com writes:

https://github.com/dtaht/sch_cake/blob/787329d00b5ad5ad1cbd772460ed99f12d762a1a/cobalt_compat.h#L145

check please.

What's the bug? This is expected...

odkrys commented 4 years ago

it should be 

(KERNEL_VERSION(4,  1, 28) > LINUX_VERSION_CODE)
or
(KERNEL_VERSION(4,  1, 27) >=  LINUX_VERSION_CODE)

there is no qdisc_tree_reduce_backlog at Kernel 4.1.27.

tohojo commented 4 years ago

odkrys notifications@github.com writes:

it should be (KERNEL_VERSION(4, 1, 28) there is no qdisc_tree_reduce_backlog at Kernel 4.1.27.

Oh, I see what you mean; yeah, seems there's an off-by-one error there...