search

dtaht / sch_cake

Out of tree build for the new cake qdisc
100 stars 35 forks source link

pkt_sched.h should include definition of TCQ_ETS_MAX_BANDS #139

Closed gamanakis closed 4 years ago

gamanakis commented 4 years ago

Otherwise compilation of the out-of-tree module fails in recent kernels (tested with 5.7.6) with:

make[1]: Entering directory '/usr/lib/modules/5.7.6-1-vfio/build'
  CC [M]  /rex/src/git/sch_cake/sch_cake.o
In file included from /rex/src/git/sch_cake/sch_cake.c:69:
./include/net/pkt_cls.h:862:22: error: ‘TCQ_ETS_MAX_BANDS’ undeclared here (not in a function)
  862 |  unsigned int quanta[TCQ_ETS_MAX_BANDS]; /* 0 for strict bands. */
      |                      ^~~~~~~~~~~~~~~~~
make[2]: *** [scripts/Makefile.build:267: /rex/src/git/sch_cake/sch_cake.o] Error 1
make[1]: *** [Makefile:1732: /rex/src/git/sch_cake] Error 2
make[1]: Leaving directory '/usr/lib/modules/5.7.6-1-vfio/build'
make: *** [Makefile:7: default] Error 2
tohojo commented 4 years ago

Why would you compile the out of tree version against that new a kernel? Just use the in-tree version...

gamanakis commented 4 years ago

Good point. Was just used to testing things in the out-of-tree version :)