search

dtaht / sch_cake

Out of tree build for the new cake qdisc
101 stars 35 forks source link

sch_cake: remove deprecated uninitialized_var function #146

Closed aauren closed 3 years ago

aauren commented 3 years ago

With the caveat that I am not a C programmer, when I went to compile this against my new kernel from Arch (5.9.8) it no longer worked. A quick search turns up the it looks like uninitialized_var has been intended for deprecation for a while now: https://lwn.net/Articles/529954/

Fully initializing it allows sch_cake to be able to be compiled against this new kernel and should also be safe for older kernels as well.

tohojo commented 3 years ago

Kernel 5.9.8 already includes sch_cake, so this repository is only for kernels that don't. So we're generally not fixing compatibility bugs against newer kernels; why did you need to compile it? :)

aauren commented 3 years ago

Nice! I had no idea that it was in there now! I'll definitely stop doing all this extra work and just use what's built into the kernel. :stuck_out_tongue:

xnoreq commented 3 years ago

Cake's been included in linux since 4.19 over 2 years ago, but it may haven taken over a year to show up in your distro. (edit: not the case with Arch as they're fairly quick to release new kernels)

Maybe a README that mentions this and links to the wiki wouldn't hurt.

tohojo commented 3 years ago

xnoreq notifications@github.com writes:

Cake's been included in linux since 4.19 over 2 years ago, but it may haven taken over a year to show up in your distro.

Maybe a README that mentions this and links to the wiki wouldn't hurt.

Yeah, good point, I'll add a README.