search

dtamayo / spock

🖖 A package to determine whether planetary orbital configurations will live long and prosper
GNU General Public License v3.0
63 stars 15 forks source link

testing whether this triggers actions #29

Closed dtamayo closed 4 months ago

MilesCranmer commented 4 months ago

@dtamayo the reason it didn't trigger the actions is because the PR was set to point to the safetensors branch. Once the safetensors branch is merged, the PR-specific actions will run.

Although we should really modify the github actions to run them on all branches on push too.. I think https://github.com/dtamayo/spock/blob/1385216aff6e44e2bed8c763dd86deb03e54ab1b/.github/workflows/python.yml#L3 needs to be

on:
    push:
        branch:
            - '*'
    pull_request:
        branch:
            - '*'
dtamayo commented 4 months ago

Thanks! I’ll be able to work on this tonight. In case it’s helpful before then, the QuickStart.ipynb on the Caleb branch has a manual example to test the new functionality. You have to run the emulator.predict() cell twice in order for it to work due to what I wrote in the email about DeepRegressor. I don’t remember where Caleb’s model files are, but the paths are there in the init functions for CollisionMergerClassifier and CollisionOrbitaOutcomrRegressor in their respective .py files

Daniel Tamayo Assistant Professor Harvey Mudd College Past-Chair, AAS Division on Dynamical Astronomy Pronouns: he/him/él

On Sun, May 19, 2024 at 11:51 AM Miles Cranmer @.***> wrote:

@dtamayo https://github.com/dtamayo the reason it didn't trigger the actions is because the PR was set to point to the safetensors branch. Once the safetensors branch is merged, the PR-specific actions will run.

Although we should really modify the github actions to run them on all branches on push too.. I think https://github.com/dtamayo/spock/blob/1385216aff6e44e2bed8c763dd86deb03e54ab1b/.github/workflows/python.yml#L3 needs to be

on: push: branches:

  • '*' pull_request: branches:
  • '*'

— Reply to this email directly, view it on GitHub https://github.com/dtamayo/spock/pull/29#issuecomment-2119282799, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2ABFZNR6GVUDWBVXUD6Y3ZDDC7XAVCNFSM6AAAAABH6OHPUSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJZGI4DENZZHE . You are receiving this because you were mentioned.Message ID: @.***>