dtan4 / terraforming

Export existing AWS resources to Terraform style (tf, tfstate) / No longer actively maintained
http://terraforming.dtan4.net/
MIT License
4.29k stars 659 forks source link

Rename title of aws_route53_record with wildcard. #348

Closed furhouse closed 7 years ago

furhouse commented 7 years ago

Normalize '-052' to 'wildcard'.

See https://github.com/dtan4/terraforming/issues/347

This renames the title of an aws_route53_record with a wildcard to a string which can be reused without having to modify the output of terraform r53r (--tfstate).

resource "aws_route53_record" "-052-example-net-CNAME" {
    zone_id = "XYZ"
    name    = "*.example.net"
    type    = "CNAME"
    records = ["example.net."]
    ttl     = "1800"
}

->

resource "aws_route53_record" "wildcard-example-net-CNAME" {
    zone_id = "XYZ"
    name    = "*.example.net"
    type    = "CNAME"
    records = ["example.net."]
    ttl     = "1800"
}
coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling f472cca5b573047dfaeab92517ef63f02fb22c97 on furhouse:feature/route53_wildcard_record_name_fix into 80610794c89fb985ca0f1e562cda850a14b762fc on dtan4:master.

dtan4 commented 7 years ago

LGTM 👍 Thanks ❗️