dtan4 / terraforming

Export existing AWS resources to Terraform style (tf, tfstate) / No longer actively maintained
http://terraforming.dtan4.net/
MIT License
4.3k stars 658 forks source link

Render notification_topic_arn when exporting ElastiCache clusters #436

Closed mozamimy closed 5 years ago

mozamimy commented 5 years ago

I think it's good to render notification_topic_arn on .tf file and .tfstate file. Because I'm using terraforming with Terraform CLI tool with import subcommand.

In that situation, I work according to the below instructions.

If the actual resource has a notification configuration, then the terrafrom plan generates the following output.

An execution plan has been generated and is shown below.
Resource actions are indicated with the following symbols:
  ~ update in-place

Terraform will perform the following actions:

  ~ module.elasticache_redis.aws_elasticache_cluster.foo
      notification_topic_arn: "arn:aws:sns:ap-northeast-1:123456789012:bar" => ""

Plan: 0 to add, 1 to change, 0 to destroy.

I’d like the output of terraforming to eliminate diffs after run terraform import. What do you think about this?

I'm using terraforming with the following environment.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 92f101d2ec954cb1cc8c3d4a3f6ae4c8b26d6b18 on mozamimy:elasticache-cluster-notify into 1ba96b958123087dc1454e284ce34cc9c00b69a0 on dtan4:master.

dtan4 commented 5 years ago

Sorry for the late review 🙇

I’d like the output of terraforming to eliminate diffs after run terraform import. What do you think about this?

I agree with this 👍

mozamimy commented 5 years ago

Thank you!