dtan4 / terraforming

Export existing AWS resources to Terraform style (tf, tfstate) / No longer actively maintained
http://terraforming.dtan4.net/
MIT License
4.3k stars 657 forks source link

add mfa support to assume role #463

Open cmedley opened 5 years ago

cmedley commented 5 years ago

This enables using mfa device with assume role

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling caf65768f9bd5147085d242bcf1b203349d6a27c on cmedley:assume-role-with-mfa-support into 50e09f973ec01ccb0751741eed4d78acb1c3cdb3 on dtan4:master.

dimisjim commented 5 years ago

Documented successful run of this in: https://github.com/dtan4/terraforming/issues/356

Let's merge!

jamengual commented 5 years ago

Is there any reason why this can't be merged ? we use assume role in all our accounts so without this it renders terraforming useless. Thanks.