search

dtan4 / terraforming

Export existing AWS resources to Terraform style (tf, tfstate) / No longer actively maintained
http://terraforming.dtan4.net/
MIT License
4.3k stars 659 forks source link

Improve s3 #477

Open alexdotsh opened 5 years ago

alexdotsh commented 5 years ago

This is an addition to the original work that was done by sergeylanzman - [PR] here (https://github.com/dtan4/terraforming/pull/396)

I've only added the tests that was necessary to cover the changes in the code.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling e5556b6e3b15171511f70f546fc7a513e015cf2e on alexmirkhaydarov:improve-s3 into 67cb9299f283bc16bd70c197f25edc419bee280f on dtan4:master.

philnichol commented 4 years ago

Can this be merged? This looks extremely helpful :)