dtao / safe_yaml

Parse YAML safely
MIT License
217 stars 63 forks source link

Permissions incorrect in safe_yaml-0.9.2.gem #40

Closed josephholsten closed 11 years ago

josephholsten commented 11 years ago

In the last release of the gem, the lib/safe_yaml.rb file has mode 640. This makes it unreadable (thus unusable) by normal users when installed by root as a system gem.

dtao commented 11 years ago

What?! Ugh, how did I let that happen? Embarrassing.

I will fix this later today. Unfortunately I'm on vacation in Croatia without consistent internet access at the moment.

In the meantime I guess the only option for users installing SafeYAML as a system gem is to manually repair the permissions :(

josephholsten commented 11 years ago

It happens! Oddly enough, the modified date of the file is 1969-01-01 also. Something funky happened.

http://josephholsten.com

On Jun 4, 2013, at 22:34, Dan Tao notifications@github.com wrote:

What?! Ugh, how did I let that happen? Embarrassing.

I will fix this later today. Unfortunately I'm on vacation in Croatia without consistent internet access at the moment.

In the meantime I guess the only option for users installing SafeYAML as a system gem is to manually repair the permissions :(

— Reply to this email directly or view it on GitHub.

sosedoff commented 11 years ago

Also found this issue when using on default mac ruby 1.8.7.

josephholsten commented 11 years ago

To make ticket this more googlable, here's an error message from this issue:

$ bundle install
<snip>
Using safe_yaml (0.9.2) 
Using strainer (2.1.0) 
Using test-kitchen (1.0.0.alpha.6) 
Using bundler (1.2.3) 
Your bundle is complete! Use `bundle show [gemname]` to see where a bundled gem is installed.
jpipes@uberbox:~/repos/jaypipes/cookbook-galera$ bundle exec kitchen init
D, [2013-06-03T18:18:12.113016 #12123] DEBUG -- : Shutdown completed cleanly
/var/lib/gems/1.9.1/gems/test-kitchen-1.0.0.alpha.6/lib/kitchen/loader/yaml.rb:21:in `require': cannot load such file -- safe_yaml (LoadError)
    from /var/lib/gems/1.9.1/gems/test-kitchen-1.0.0.alpha.6/lib/kitchen/loader/yaml.rb:21:in `<top (required)>'
    from /var/lib/gems/1.9.1/gems/test-kitchen-1.0.0.alpha.6/lib/kitchen.rb:39:in `require'
    from /var/lib/gems/1.9.1/gems/test-kitchen-1.0.0.alpha.6/lib/kitchen.rb:39:in `<top (required)>'
    from /var/lib/gems/1.9.1/gems/test-kitchen-1.0.0.alpha.6/lib/kitchen/cli.rb:24:in `require'
    from /var/lib/gems/1.9.1/gems/test-kitchen-1.0.0.alpha.6/lib/kitchen/cli.rb:24:in `<top (required)>'
    from /var/lib/gems/1.9.1/gems/test-kitchen-1.0.0.alpha.6/bin/kitchen:10:in `require'
    from /var/lib/gems/1.9.1/gems/test-kitchen-1.0.0.alpha.6/bin/kitchen:10:in `<top (required)>'
    from /usr/local/bin/kitchen:23:in `load'
    from /usr/local/bin/kitchen:23:in `<main>'
jpipes@uberbox:~/repos/jaypipes/cookbook-galera$ gem query --local | grep safe_yaml
safe_yaml (0.9.2)

found at https://github.com/opscode/test-kitchen/issues/137

dtao commented 11 years ago

OK, this should be fixed in version 0.9.3 (kinda weird to create a new version just for file permissions, but that seemed the most expedient solution to me).

josephholsten commented 11 years ago

Can you also yank 0.9.2? If there are no other changes in 0.9.3 than permissions, there should be no reason to continue having folks use it.

dtao commented 11 years ago

@josephholsten Agreed—done.