search

dtarb / TauDEM

Terrain Analysis Using Digital Elevation Models (TauDEM) software for hydrologic terrain analysis and channel network extraction.
http://hydrology.usu.edu/taudem
Other
222 stars 115 forks source link

Compilation errors #263

Open julemai opened 2 months ago

julemai commented 2 months ago

Hi there,

I cloned the Develop branch and try to compile it (using make) on MacOS/Linux. I am using mpicxx version 15.0.0. I am however getting error messages like:

In file included from streamnet.cpp:56:
./linklib.h:281:2: error: static assertion failed: MPI_Type_extent was removed in MPI-3.0.  Use MPI_Type_get_extent instead.
        MPI_Type_extent(MPI_LONG, &extent);
        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/opt/homebrew/Cellar/open-mpi/5.0.3/include/mpi.h:3183:31: note: expanded from macro 'MPI_Type_extent'
#define MPI_Type_extent(...)  THIS_FUNCTION_WAS_REMOVED_IN_MPI30(MPI_Type_extent, MPI_Type_get_extent)
                              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/opt/homebrew/Cellar/open-mpi/5.0.3/include/mpi.h:361:59: note: expanded from macro 'THIS_FUNCTION_WAS_REMOVED_IN_MPI30'
#define THIS_FUNCTION_WAS_REMOVED_IN_MPI30(func, newfunc) static_assert(0, #func " was removed in MPI-3.0.  Use " #newfunc " instead.")
                                                          ^             ~

Would you want me to resolve these in a separate branch and create a pull request in case I am able to resolve them? Should I work off the Develop branch or the Master? Or would you like to look into this? Which compiler version are you using. I could also just try to downgrade to an older compiler.

Thanks, Julie

julemai commented 2 months ago

Please see here the full output of the compilation (including all warnings and error messages). TauDEM_compile_output.txt

dtarb commented 2 months ago

If you can resolve thse in a branch from Develop and make a pull request, that would be great. I use a PC with Windows, however have not worked on TauDEM for a while.

julemai commented 2 months ago

Sounds good. I will try if I get that running.

Could you give me write permissions? I currently can't create a branch.

julemai commented 2 months ago

Resolved all errors and some additional warnings. Just waiting to be able to publish the branch and get the pull request done. :)

dtarb commented 2 months ago

@julemai I'd prefer it if you cloned the repository and made a pull request against the code in your clone. See https://github.com/orgs/community/discussions/49745 (or elsewhere) for guidance on this.

julemai commented 2 months ago

I don't get that running. It just doesn't let me publish any branch that I create even following above.

I will just work with the local version I have now. I also saw that there is a pull request from 2022 that might solve the outdated MPI commands already.

I'm happy if you close this issue.