search

dtauerbach / apollo

Apollo Project website
1 stars 0 forks source link

poopup modal when clicked on data source on /dashboard #14

Closed psawaya closed 10 years ago

psawaya commented 11 years ago

name of data source

icon associated with data source

type of data source (of three types: oauth, scraping, manual upload) that render appropriate modal interfaces

dtauerbach commented 11 years ago

This looks fantastic. I've only glanced at the code, and it looks good except one question: I haven't seen such a services.json file made available in a URL (maybe because I don't do much web programming). Is there a reason to do it this way? Instead of, say, in the dashboard() function grabbing the info from a database and creating a JSON object and passing that to the template? My intuition is to lock down the number of visible URLs -- especially ones with raw data -- but I suppose it doesn't matter much.

I'm going to leave this issue open for my purposes but you can consider the requirement satisfied.

psawaya commented 11 years ago

Yes, I think you'll eventually want to create services.json from the database. It will make the page will load faster (and eliminate one externally visible URL) if you generate the services object in a script tag instead of a JSON file, so that may be a good idea. Additionally, you might want to look at something like underscore for templating.