dtcarls / fantasy_football_chat_bot

GroupMe Discord and Slack Chatbot for ESPN Fantasy Football
GNU General Public License v3.0
297 stars 235 forks source link

Score update has inflated scores for a matchup #44

Closed csabatini closed 5 years ago

csabatini commented 5 years ago

Describe the bug Score update has scores for a matchup that are too high for both teams.

Screenshots Message text copied from Slack:

Actual Score Update
SHIT 123.16 - 53.16 8==D
SABA 50.56 - 61.34 WALK
HELP 99.50 - 103.62 CUT
TRM 153.38 - 67.70 BOMB
BURN 118.72 - 102.34 DEAD
Free 135.54 - 95.20 ROMO
BERB 118.62 - 49.92 MEAT

From ESPN app, the third score should be: HELP 86.5 - 88.6 CUT

Chat application Slack

Additional context

LEAGUE_ID=14434
SWID=D2B41879-14A0-47CC (modified to keep information private)
ESPN_S2=AEArqDpgkK5KQaO2 (modified to keep information private)
csabatini commented 5 years ago

Fractional part of the score looks correct, but one is offset by 13 points and the other by 15 points

csabatini commented 5 years ago

When I use ff_espn_api for my league and look at league.box_scores(1)[2].home_score and away_score, they look right (86.5 and 88.62). I'm not sure if there are any other steps that would be adding points to this?

1568052692429

csabatini commented 5 years ago

I see the scoreboard method is pretty much a straight pull from the API data. Maybe ESPN was bugged at that moment?

dtcarls commented 5 years ago

Certainly possible. ESPN was very buggy over the weekend with some week 1 stuff. Let me know if it continues

dtcarls commented 5 years ago

Seems to be happening even with latest version in some leagues. See https://github.com/dtcarls/fantasy_football_chat_bot/issues/45

This will be very difficult to troubleshoot while a game is in progress. If the problem persists, can you provide your league id. If your league is not public please provide a screenshot of the full lineups (with bench) of the teams that have reported and inflated score and the incorrect corresponding message.

csabatini commented 5 years ago

Sounds good. Close scores message from tonight also showed the same inflated scores for the matchup above.

I'm curious if the final score update tomorrow morning will be accurate, if not I will post the details.

dtcarls commented 5 years ago

Opened issue with upstream library (above)

Correy27 commented 5 years ago

The final scores today along with all the trophies were correct. I had the inflated scores issue for one match-up yesterday on the close scores update.

dtcarls commented 5 years ago

Closing as upstream issue was closed. Reopen if problem persists.