search

dtcarls / fantasy_football_chat_bot

GroupMe Discord and Slack Chatbot for ESPN Fantasy Football
GNU General Public License v3.0
296 stars 234 forks source link

Actual Score Update -- Friday AM Shows LW #48

Closed Carbja23 closed 5 years ago

Carbja23 commented 5 years ago

Describe the bug Actual Score Update (7:30AM EST) update is last week's scores.

Expected behavior Should show only scores from the Thursday Night Game

bs0l commented 5 years ago

Having the same issue

HennDev commented 5 years ago

I'm seeing the same thing. I think this is related to the get_current_week() function, I think line 102ish of ff_bot.py.

Since it's only looking at a single team's score, if that team doesn't have anyone on Thursday, it deduces nobody has a score and it's a "future week".

dtcarls commented 5 years ago

Thinking the same thing. Not sure why it would've worked last year. Working to fix.

On Fri, Sep 13, 2019 at 8:42 AM HennDev notifications@github.com wrote:

I'm seeing the same thing. I think this is related to the get_current_week() function, I think like 102ish.

Since it's only look at a single team's score, if that team doesn't have anyone on Thursday, it deduces nobody has a score and it's a "future week".

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dtcarls/fantasy_football_chat_bot/issues/48?email_source=notifications&email_token=ACWGOWKJKZIVUI3U66PJPP3QJODCRA5CNFSM4IWO54V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6U43JA#issuecomment-531221924, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWGOWMGWF6TGENQB4ADNXTQJODCRANCNFSM4IWO54VQ .

HennDev commented 5 years ago

I blame ESPNs horrible design!

foobartles commented 5 years ago

https://github.com/dtcarls/fantasy_football_chat_bot/issues/47

I imagine this issue is also being caused by the same thing. I think the problem code is coming from the league.scoreboard() call

ZachMyers3 commented 5 years ago

Submitted a PR to fix the issue #49.

dtcarls commented 5 years ago

Potentially fixed with latest merges. Leaving ticket open for a week for verification

nez-the-old commented 5 years ago

dtcarls - Does your merge fix filter down to us peons automatically or do we have to reinstall the bot?

dtcarls commented 5 years ago

Unfortunately you have to reinstall. A lot of bugs this year with the new API and even bugs with ESPNs data. Hopefully this is the last of the major ones.

On Fri, Sep 13, 2019 at 12:26 PM nez-the-old notifications@github.com wrote:

dtcarls your merge fix filter down to us peons automatically or do we have to reinstall the bot?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/dtcarls/fantasy_football_chat_bot/issues/48?email_source=notifications&email_token=ACWGOWO2RRCHGJZUL5U2WXDQJO5KBA5CNFSM4IWO54V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD6VQ3KY#issuecomment-531303851, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWGOWL67VHL4XPKLCYXHI3QJO5KBANCNFSM4IWO54VQ .

nez-the-old commented 5 years ago

Hey man no worries! I appreciate you supporting this fun bot!

dtcarls commented 5 years ago

Closing issue as it didn't occur over the weekend with latest version. Reopen if problem re-occurs