search

dtcarls / fantasy_football_chat_bot

GroupMe Discord and Slack Chatbot for ESPN Fantasy Football
GNU General Public License v3.0
297 stars 234 forks source link

Projected scores incorrect when player scores 0 #51

Closed dtcarls closed 5 years ago

dtcarls commented 5 years ago

Describe the bug When a player is projected to score more than 0 but then scores 0 the projection overrides the actual score.

To Reproduce OJ Howard week 2

Expected behavior After a game has ended if the player remains with 0 points, use that instead of projected.

dtcarls commented 5 years ago

watching https://github.com/cwendt94/ff-espn-api/issues/44

cwendt94 commented 5 years ago

In ff_espn_api version 1.1.4 I added a field in box_player called “game_played”. If they haven’t played yet that value will be 0 if they are done paying the value will be 100.

I would keep this 1.1.4 change in develop branch for a week just to make sure nothing else broke. A decent amount of logic has been added to box_scores endpoint.

nmpeterson commented 5 years ago

Was this tested this week? Rams defense scored 0 for me this week and the projected score update still credited them with the original projection.

dtcarls commented 5 years ago

It has not been integrated or tested yet. It will likely go through beta this coming week.

On Mon, Sep 30, 2019 at 10:28 AM Noel Peterson notifications@github.com wrote:

Was this tested this week? Rams defense scored 0 for me this week and the projected score update still credited them with the original projection.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/dtcarls/fantasy_football_chat_bot/issues/51?email_source=notifications&email_token=ACWGOWIXJSU4CRL53KGRS53QMIEIVA5CNFSM4IWRMLJ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD752Z6A#issuecomment-536587512, or mute the thread https://github.com/notifications/unsubscribe-auth/ACWGOWLGASDJ33LIVCT7JY3QMIEIVANCNFSM4IWRMLJQ .

dtcarls commented 5 years ago

In beta this week in the the develop branch

dtcarls commented 5 years ago

Worked over the weekend. Will merge into master once I validate https://github.com/dtcarls/fantasy_football_chat_bot/issues/62 tonight.