dtcenter / MET

Model Evaluation Tools
https://dtcenter.org/community-code/model-evaluation-tools-met
Apache License 2.0
77 stars 24 forks source link

Remove ensemble post-processing from the Ensemble-Stat tool. #1908

Closed JohnHalleyGotway closed 1 year ago

JohnHalleyGotway commented 3 years ago

Describe the Enhancement

MET#1904 added a new Gen-Ens-Prod ensemble post-processing tool to MET version 10.1.0, and MET#1907 warned users that ensemble product generation would be removed from Ensemble-Stat in a future version. This issue is to strip the processing of the "ens" dictionary, along with ensemble product generation options out of the Ensemble-Stat tool.

Need to more carefully define which, if any, of the "ensemble_flag" options should remain. For example, depending on the "output_flag" options requested, Ensemble-Stat will still need to compute the ensemble mean, standard deviation, and gridded ranks. Should it retain the ability to write those fields to an output NetCDF file?

Propose REMOVING minus, plus, min, max, range, frequency, nep, and nmep, leaving the following options which remain:

ensemble_flag = {
   latlon    = TRUE;
   mean      = TRUE;
   stdev     = TRUE;
   vld_count = TRUE;
   rank      = TRUE;
   weight    = TRUE;
}

Recommend that the tool check to see if the user provides and "ens" dictionary in the configuration file, and if so, error out with a useful error message. Also be sure to update the MET flowchart changing Ensemble-Stat from being green and blue, to only blue. It is a statistics generation tool (blue) but no longer does pre-processing (green).

Recommend coordinating these changes with @michelleharrold and the DTC UFS/SRW team.

Note that this work should be done in conjunction with #2139.

Time Estimate

2 days.

Sub-Issues

Consider breaking the enhancement down into sub-issues. No sub-issues needed.

Relevant Deadlines

2793541

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

Labels

Projects and Milestone

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

JohnHalleyGotway commented 1 year ago

Recommend renaming ensemble_flag to something else. Perhaps ens_rank_flag, ensemble_pairs_flag, or obs_rank_flag? This is similar in functionality to nc_pairs_flag in Grid-Stat.