dtcenter / MET

Model Evaluation Tools
https://dtcenter.org/community-code/model-evaluation-tools-met
Apache License 2.0
74 stars 22 forks source link

Fix GRIB table lookup logic for multiple matching entries #2240

Open JohnHalleyGotway opened 1 year ago

JohnHalleyGotway commented 1 year ago

Describe the Enhancement

This issue arose via GitHub discussion dtcenter/METplus#1744. Please see this comment in particular for an explanation of the issue.

Put simply, the logic for when/how both the units and long name are determined for GRIB1 and GRIB2 input data is insufficient. Currently, the MET library code uses the requested variable name, along with any other user-specified filters (e.g. GRIB2_cntr and so on), to search the GRIB tables for matches. If multiple matches are found, it just uses the first match to define the units and long name for that variable.

And that's where the problem lies. It can't actually define the units and long name until the data is actually read. Recommend refining this logic to only define the units and long name when the data is actually read rather than before it.

Time Estimate

1 day

Sub-Issues

Consider breaking the enhancement down into sub-issues. None needed.

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

Labels

Projects and Milestone

Define Related Issue(s)

Consider the impact to the other METplus components.

Enhancement Checklist

See the METplus Workflow for details.

sethlinden commented 1 year ago

@TaraJensen what account key should I use for this work.. Lately I've been using 2773542 for my MET development work. Thanks.