Feature 2673 sonarqube beta3 namespace

hsoh-u commented 4 months ago

Expected Differences

Moved down the using namespace statements below #include statements at *cc files (#2696 ).
Removed "using namespace" statements from header files (#2696 )
Added the namespace into header files, for example (string to std::string)
[x] Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
[x] Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:

Pull Request Testing

[x] Describe testing already performed for these changes:
Ran the unit test and compare the output of the nighty build

Checking using namespace statement at the header files

 find src -type f -name "*h" -o -name "*hpp"  -exec grep -nH -A 4 "using namespace" {} \;

Few cases are not fixed. They may be the generated codes.

find src -type f -name "*h" -o -name "*hpp" -o -name "*cc"  -exec grep -nH -A 4 "using namespace" {} \; | grep include |  less

[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
[x] Do these changes include sufficient testing updates? [No]
[x] Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
[ ] Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

[ ] Review the source issue metadata (required labels, projects, and milestone).
[ ] Complete the PR definition above.
[ ] Ensure the PR title matches the feature or bugfix branch name.
[ ] Define the PR metadata, as permissions allow. Select: Reviewer(s) and Development issue Select: Milestone as the version that will include these changes Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
[ ] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.

jprestop commented 4 months ago

Thank you for this work, @hsoh-u. Would you say that this PR also covers the work described in this issue Move namespace specifications below include directives #2696? If so, let's link in this issue under "Development" as well, and thanks for doing the work I had planned to do, but had not gotten to yet!

hsoh-u commented 4 months ago

Added it to "Expected Differences". I can not add #2696 to Development. Typing 269 shows 2697 only and typing move does not work.

dtcenter / MET