dtcenter / MET

Model Evaluation Tools
https://dtcenter.org/community-code/model-evaluation-tools-met
Apache License 2.0
74 stars 22 forks source link

Feature #2673 enum_to_string #2835

Closed JohnHalleyGotway closed 4 months ago

JohnHalleyGotway commented 4 months ago

The enum_to_string utility logic needs to be updated to create code consistent with the SonarQube standards. To demonstrate the issue, I ran the following commands on seneca:

cd /d1/personal/johnhg/MET/MET_development/MET-develop
git checkout develop
source internal/scripts/environment/development.seneca
./bootstrap
make clean install
git status

And here's the files with diffs:

modified:   src/basic/vx_config/celltype_to_string.cc
modified:   src/basic/vx_config/config.tab.cc
modified:   src/basic/vx_config/configobjecttype_to_string.cc
modified:   src/libcode/vx_bool_calc/tokentype_to_string.cc

These are mostly output from the enum_to_string utility. Fixing that should minimize these diffs. For this PR, I did the following:

Beyond changes in src/basic/enum_to_string and in the .yy and .ll input files, the diffs for this PR are almost non-existent. The diff in configobjecttype_to_string.cc is just the removal of one blank line.

Expected Differences

Pull Request Testing

Pull Request Checklist

See the METplus Workflow for details.