Bugfix #2833 develop azimuth

JohnHalleyGotway commented 4 months ago

This PR removes the max_range_km config option from the TC-RMW config file and corrects off-by-one bugs in the handling of both dimensions of the range/azimuth grids used by the TC-RMW and TC-Diag tools.

Expected Differences

[x] Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
[x] Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:

Pull Request Testing

[x] Describe testing already performed for these changes:
Please see this issue comment for details of the testing I did.
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review the documentation updates in the tc_rmw Configuration File section.
Review the code changes.
Review the differences flagged by the GHA testing workflow run for this PR. Note that diffs should only appear in the output from the TC-RMW and TC-Diag tools.
Test the code for this PR as you see fit in seneca:/d1/projects/MET/MET_pull_requests/met-12.0.0/beta4/MET-bugfix_2833_develop_azimuth/bin/.
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
[x] Do these changes include sufficient testing updates? [Yes] Modifies the config files used by existing tests of the TC-RMW tool.
[x] Will this PR result in changes to the MET test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
The re-configured TC-RMW tests will produce different results and cause the regression test to fail:
TCRMWConfig_gonzalo will now use delta_range_km = 10.0; instead of RMW.
TCRMWConfig_pressure_lev_out uses rmw_scale = 0.2;, but fixing these bugs will produce different output.
[x] Will this PR result in changes to existing METplus Use Cases? [Yes]
If yes, create a new Update Truth METplus issue to describe them. Fixing these bugs will change the results for any METplus Use Cases that run TC-RMW or TC-Diag.
[x] Please complete this pull request review by [Fri 3/21/24].

Pull Request Checklist

See the METplus Workflow for details.

[x] Review the source issue metadata (required labels, projects, and milestone).
[x] Complete the PR definition above.
[x] Ensure the PR title matches the feature or bugfix branch name.
[x] Define the PR metadata, as permissions allow. Select: Reviewer(s) and Development issue Select: Milestone as the version that will include these changes Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
[x] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[ ] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.

JohnHalleyGotway commented 4 months ago

Note that this Pull Request DOES NOT do anything to fix the radial/tangential wind computations. I think we should get this bug fixed and then re-test and re-evaluate that issue. If issues remain with radial/tangential winds, let's use another bugfix issue to describe/fix them.

JohnHalleyGotway commented 3 months ago

@KathrynNewman can you please provide an estimate on when you can get this PR reviewed as well as the corresponding PR #2834?

dtcenter / MET