Note that is a pull request to merge change from the feature_2830_bootstrap_enum branch into the feature_2830_sonarqube_enum branch. @hsoh-u is working on most of the changes, and this PR provides updates to the handling of the BootIntervalType enumeration.
Expected Differences
[x] Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
[x] Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
[x] Describe testing already performed for these changes:
Only confirmed that these changes compile and that make install runs without error.
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Since this was not a PR for the develop branch, the full regression test was NOT RUN via GHA. Instead, I manually triggered the following Testing Workflow run:
https://github.com/dtcenter/MET/actions/runs/8397559365
Please check to confirm that it ran without error and flagged no diffs.
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
None needed.
[x] Do these changes include sufficient testing updates? [Yes]
None needed.
[x] Will this PR result in changes to the MET test suite? [No]
If yes, describe the new output and/or changes to the existing output:
[x] Will this PR result in changes to existing METplus Use Cases? [No]
If yes, create a new Update TruthMETplus issue to describe them.
[x] Please complete this pull request review by [Tues 3/26/24].
[x] Review the source issue metadata (required labels, projects, and milestone).
[x] Complete the PR definition above.
[x] Ensure the PR title matches the feature or bugfix branch name.
[x] Define the PR metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
[x] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[x] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[ ] Close the linked issue and delete your feature or bugfix branch from GitHub.
Note that is a pull request to merge change from the
feature_2830_bootstrap_enum
branch into thefeature_2830_sonarqube_enum
branch. @hsoh-u is working on most of the changes, and this PR provides updates to the handling of theBootIntervalType
enumeration.Expected Differences
[x] Do these changes introduce new tools, command line arguments, or configuration file options? [No] If yes, please describe:
[x] Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No] If yes, please describe:
Pull Request Testing
[x] Describe testing already performed for these changes: Only confirmed that these changes compile and that
make install
runs without error.[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions: Since this was not a PR for the develop branch, the full regression test was NOT RUN via GHA. Instead, I manually triggered the following Testing Workflow run: https://github.com/dtcenter/MET/actions/runs/8397559365
Please check to confirm that it ran without error and flagged no diffs.
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes] None needed.
[x] Do these changes include sufficient testing updates? [Yes] None needed.
[x] Will this PR result in changes to the MET test suite? [No] If yes, describe the new output and/or changes to the existing output:
[x] Will this PR result in changes to existing METplus Use Cases? [No] If yes, create a new Update Truth METplus issue to describe them.
[x] Please complete this pull request review by [Tues 3/26/24].
Pull Request Checklist
See the METplus Workflow for details.