dtcenter / MET

Model Evaluation Tools
https://dtcenter.org/community-code/model-evaluation-tools-met
Apache License 2.0
77 stars 24 forks source link

Feature 2830 sonarqube enum #2849

Closed hsoh-u closed 6 months ago

hsoh-u commented 6 months ago

Expected Differences

The same functionalities but changed the code enum to enum class.

Pull Request Testing

Unittest

N/A

It may increase the findings because other rules were not applied at the modified codes.

Pull Request Checklist

See the METplus Workflow for details.

hsoh-u commented 6 months ago

Not sure why duplication was increased by changing enum to enum class. The most new code smells are actually the existing ones, for example, case(xxx) as redundant parentheses. The same lines were changed during enum class but I did not correct them to focus enum class issue.