This PR updates MET to accomplish the tasks listed in this GitHub issue comment.
Assigns code version number to SonarQube scan.
Structures the properties file in the same way as the other METplus repos.
Consolidates 2 SonarQube scans into a single one.
Adds more error checking so that a failed scan will cause the scanning step to return bad status rather than waiting for the quality gate step to fail.
Deletes point.py file inadvertently added during development several years ago.
Moves rgb2ctable.py script into the python utilities directory for easy SonarQube scanning.
It turns out that including the Python code in the same scan as the rest of the MET C/C++ code is just a one-liner. For simplicity, I recommend we consolidate back into a single SonarQube run for MET. This PR consolidates both the GitHub action and the nightly build logic into doing a single run.
The MET GHA project contains output for that single run for both the develop and main_v11.1 branches.
The MET Nightly Build project is ready and waiting for be used as a single project for the nightly build runs. It contains output for both the develop and main_v11.1 branches.
This MET Nightly Build version has the C/C++ scans and the MET python Nightly Build has the Python scans. I'm leaving them there since they contain the scan history. But I'd recommend that we eventually remove them, once that history is no longer needed for Air Force reporting purposes.
Expected Differences
[x] Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
[x] Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
[x] Describe testing already performed for these changes:
Ran scripts manually to push baseline results for both the develop and main_v11.1 scans. Confirmed that the combined scan bugs (7) equals the sum of the individuals scans for C/C++ (5) and Python (2).
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review the proposed code changes and comment on the proposal of consolidating back into a single scan for MET.
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
None needed.
[x] Do these changes include sufficient testing updates? [Yes]
None needed.
[x] Will this PR result in changes to the MET test suite? [No]
If yes, describe the new output and/or changes to the existing output:
[x] Will this PR result in changes to existing METplus Use Cases? [No]
If yes, create a new Update TruthMETplus issue to describe them.
[x] Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
[x] Please complete this pull request review by [Tues 4/9].
[x] Review the source issue metadata (required labels, projects, and milestone).
[x] Complete the PR definition above.
[x] Ensure the PR title matches the feature or bugfix branch name.
[x] Define the PR metadata, as permissions allow.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or MET-X.Y.Z Development project for official releases
[x] After submitting the PR, select the :gear: icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
[x] After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
[x] Close the linked issue and delete your feature or bugfix branch from GitHub.
This PR updates MET to accomplish the tasks listed in this GitHub issue comment.
point.pyfile inadvertently added during development several years ago.rgb2ctable.pyscript into the python utilities directory for easy SonarQube scanning.It turns out that including the Python code in the same scan as the rest of the MET C/C++ code is just a one-liner. For simplicity, I recommend we consolidate back into a single SonarQube run for MET. This PR consolidates both the GitHub action and the nightly build logic into doing a single run.
developandmain_v11.1branches.developandmain_v11.1branches.Expected Differences
[x] Do these changes introduce new tools, command line arguments, or configuration file options? [No] If yes, please describe:
[x] Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No] If yes, please describe:
Pull Request Testing
[x] Describe testing already performed for these changes: Ran scripts manually to push baseline results for both the
developandmain_v11.1scans. Confirmed that the combined scan bugs (7) equals the sum of the individuals scans for C/C++ (5) and Python (2).[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions: Review the proposed code changes and comment on the proposal of consolidating back into a single scan for MET.
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes] None needed.
[x] Do these changes include sufficient testing updates? [Yes] None needed.
[x] Will this PR result in changes to the MET test suite? [No] If yes, describe the new output and/or changes to the existing output:
[x] Will this PR result in changes to existing METplus Use Cases? [No] If yes, create a new Update Truth METplus issue to describe them.
[x] Do these changes introduce new SonarQube findings? [No] If yes, please describe:
[x] Please complete this pull request review by [Tues 4/9].
Pull Request Checklist
See the METplus Workflow for details.