Closed DanielAdriaansen closed 2 months ago
@willmayfield can you take a quick look at the updated docs before we merge? Here is the link: https://met.readthedocs.io/en/feature_2748_document_ugrid/Users_Guide/appendixH.html
@JohnHalleyGotway @hsoh-u this is ready to go but GitHub says: "At least 1 approving review is required to merge this pull request."
Must be @willmayfield review does not count as an "approving review"?
Could someone add their review so this can be merged? Thanks.
Closes #2748
View the documentation here: https://met--2869.org.readthedocs.build/en/2869/Users_Guide/appendixH.html
[x] Do these changes introduce new tools, command line arguments, or configuration file options? [Yes or No] If yes, please describe: No
[x] Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [Yes or No] If yes, please describe: No
Pull Request Testing
[x] Describe testing already performed for these changes: I built the docs locally on Seneca and viewed them in my browser. They appear as I expect them to.
[x] Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions: Review content for accuracy of what the code is doing. Review for missing content. Review for important limitations I may have left out.
[x] Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes or No] Yes
[x] Do these changes include sufficient testing updates? [Yes or No] Yes
[x] Will this PR result in changes to the MET test suite? [Yes or No] If yes, describe the new output and/or changes to the existing output: No
[x] Will this PR result in changes to existing METplus Use Cases? [Yes or No] If yes, create a new Update Truth METplus issue to describe them. No
[x] Do these changes introduce new SonarQube findings? [Yes or No] If yes, please describe: No
[ ] Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.